Ensure /db is included in git repo of plugin #11692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schneems Good catch! Maybe we should change the sqlite3 adapter to ensure the directory for the file exists when it receives the configuration? Even if we put a |
|
I'll look into pushing the fix to sqlite3 |
While generating a plugin that does not use the database, and empty `db/` folder will be created if the `seeds.rb` file is removed from the folder. Git does not recognise empty directories, so it will not add the `/db` folder to source. See the output here: https://github.com/schneems/default-rails-plugin Then any tests run on a remote machine will fail: http://stackoverflow.com/questions/17955787/sqlite3cantopenexception-unable-to-open-database-file-while-testing-ruby-gem Either we can include the `seeds.rb` file in the generate output of `rails plugin new` or we could add a blank `.gitignore` file to ensure that the `/db` folder is included in the git repo. I don't see a good reason for removing the file (it only has comments anyway) and all tests pass even when we keep the file in the repo. You won't run into this problem is you run a migration in your plugin's tests since that creates a `db/migrate` folder. All tests pass Railties.
schneems
added a commit
to schneems/rails
that referenced
this pull request
Aug 5, 2013
If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to rails#11692 as suggested by @josevalim
|
closing in favor of #11763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating a plugin that does not use the database, an empty
db/folder will be created if theseeds.rbfile is removed from the folder. Git does not recognise empty directories, so it will not add the/dbfolder to source. See the output here: https://github.com/schneems/default-rails-pluginThen any tests run on a remote machine will fail:
http://stackoverflow.com/questions/17955787/sqlite3cantopenexception-unable-to-open-database-file-while-testing-ruby-gem
Either we can include the
seeds.rbfile in the generate output ofrails plugin newor we could add a blank.gitignorefile to ensure that the/dbfolder is included in the git repo.I don't see a good reason for removing the file (it only has comments anyway) and all tests pass even when we keep the file in the repo.
You won't run into this problem is you run a migration in your plugin's tests since that creates a
db/migratefolder.All tests pass Railties.