Make Rake::DSL methods available within Railtie rake_tasks block

[bilts]

Fixes incompatibility introduced by Rake 0.9.0

As of Rake 0.9.0, methods such as 'task' are no longer available globally. They're placed in Rake::DSL instead. This breaks Rails::Application's initialize_tasks method. It also breaks subclasses of Railties which call Rake's methods in a rake_tasks block.

I've updated Rails::Railtie to extend Rake::DSL (if available) before loading tasks, so that formerly-global rake methods can still be called within rake_tasks blocks. I also updated Rails::Application to add its tasks within a rake_task block so it can use the rake DSL methods without issues.

This fixes issue 1171. The code is compatible with Rake 0.9.0 and Rake 0.8.7.

The change needs to be back-ported to the 3-0-stable branch as well.

[gnufied]

+1, This is a valid patch and fixes many of the failing tests.

[rohitarondekar]

+1
This fixes failing tests in railties and allows a rails 3.1.0.beta-1 app to run rake tasks! :)

[dhh]

I wonder if we should wait an see what happens with Rake 0.9.1. The change was very backwards incompatible. You'd think they'd at least go to Rake 1.0 to make it.

[jasnow]

Unclear if this is in 3-1-stable branch.

Getting these messages during RUBYOPTS="-W0" rake test:

...WARNING: Global access to Rake DSL methods is deprecated. Please include
... Rake::DSL into classes and modules which use the Rake DSL methods.
WARNING: DSL method Class#task called at /Users/whitemac/source/rails/railties/tmp/app/config/application.rb:48:in block in <class:Application>' ..WARNING: Global access to Rake DSL methods is deprecated. Please include ... Rake::DSL into classes and modules which use the Rake DSL methods. WARNING: DSL method Class#task called at /Users/whitemac/source/rails/railties/tmp/app/config/application.rb:44:inblock in class:Application'**

[jasnow]

Here my Gist of my run

https://gist.github.com/1101548