Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid defining multibyte method names in JSON decoding test for JRuby Compatitibility #11789

Merged
merged 1 commit into from Aug 7, 2013
Merged

Conversation

gaurish
Copy link
Contributor

@gaurish gaurish commented Aug 7, 2013

This change is similar to #11736 & in same way switched with fixed string & the index of the hash for method name. the index was added because otherwise, ruby will raise Error.

Before this change:

JRuby: raised an NoMethodError when running the decoding tests.
MRI: all green.

After this change

JRuby: All green 👍
MRI: all green(no change)
#11700

cc: @steveklabnik @guilleiguaran @arunagw

… Compat

This change is similar to #11736 & in same way switched with fixed string & the index of the hash for method name. the index was added because otherwise, ruby will raise Error.
steveklabnik added a commit that referenced this pull request Aug 7, 2013
Avoid defining multibyte method names in JSON decoding test for JRuby Compatitibility
@steveklabnik steveklabnik merged commit 4343e2d into rails:master Aug 7, 2013
@steveklabnik
Copy link
Member

Thank you!

@gaurish gaurish deleted the multibyte_methods branch August 7, 2013 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants