Generalize backtrace check on DelegationError. #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The current solution seems to be prone for false positives though. Maybe we could rescue and use respond_to? to check if it is avaialble or not, instead of relying on stacktraces? |
Different Ruby implementations present backtraces differently, as it should be an information consumed by humans. A better implementation should use data from the error, in this case returned by NoMethodError#name. Fixes issues with Rubinius, which presents backtraces differently from MRI.
Spent some more time on it and managed to remove backtraces completely by using |
|
Neat! 👍 |
rafaelfranca
added a commit
that referenced
this pull request
Aug 21, 2013
Generalize backtrace check on DelegationError.
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different Ruby implementations present backtraces differently, as it should be an information consumed by humans.
A better implementation should use data from the error, in this case returned by NoMethodError#name.
Fixes issues with Rubinius, which presents backtraces differently from MRI.
/cc @dbussink