Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for including nokogiri in Gemfile for rake doc:guides #11973

Merged
merged 1 commit into from
Aug 26, 2013

Conversation

prathamesh-sonpatki
Copy link
Member

  • When rake doc:guides is run from applications, it complains for
    presence of redcarpet if it not present in Gemfile
  • Similarly it should complain about nokogiri

…es [ci skip]

- When `rake doc:guides` is run from applications, it complains for
  presence of redcarpet if it not present in Gemfile
- Similarly it should complain about nokogiri
@prathamesh-sonpatki
Copy link
Member Author

/cc @senny

@steveklabnik
Copy link
Member

Seems fine.

@senny
Copy link
Member

senny commented Aug 26, 2013

thank you 💛

senny added a commit that referenced this pull request Aug 26, 2013
Add error message for including nokogiri in Gemfile for rake doc:guides
@senny senny merged commit 55c9109 into rails:master Aug 26, 2013
senny added a commit that referenced this pull request Aug 26, 2013
Add error message for including nokogiri in Gemfile for rake doc:guides
@prathamesh-sonpatki prathamesh-sonpatki deleted the nokogiri-warning branch March 3, 2016 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants