Closes #12278. AR::ConnectionAdapters::Column.string_to_time method respects string with timezone. #12290
Conversation
|
I've updated this PR to simplify testcase. |
|
The way of this Pull Request solves original reporter's problem #12278 (comment) . Is this feature unnecessary for us ? |
|
cc @pixeltrix |
ghost
assigned 
| @@ -110,6 +110,11 @@ def test_type_cast_duration_to_integer | |||
| assert_equal 1800, column.type_cast(30.minutes) | |||
| assert_equal 7200, column.type_cast(2.hours) | |||
| end | |||
|
|
|||
| def test_string_to_time_with_timezone | |||
| assert_equal Time.utc(2013, 9, 4, 0, 0, 0), Column.string_to_time("Wed, 04 Sep 2013 09:00:00 JST") | |||
There was a problem hiding this comment.
What happens if default_timezone is :local ?
There was a problem hiding this comment.
It's working fine, so a string has timezone.
:local setting returns Time.local(2013, 9, 4, 9, 0, 0) (Time.utc(2013, 9, 4, 0,0,0)) in the above testcase.
I'm going to update testcase.
|
I've updated a testcase. |
|
|
||
| time -= offset | ||
| time.send("get#{Base.default_timezone}") | ||
| end |
There was a problem hiding this comment.
Can you reverse the condition - unless … else … end is hard to parse.
There was a problem hiding this comment.
ha. I'll use if ... else ...end. just a moment.
|
I've updated again. |
| return nil unless time | ||
|
|
||
| time -= offset | ||
| time.send("get#{Base.default_timezone}") |
There was a problem hiding this comment.
This may be a hot spot if you're loading a lot of AR objects so I'd rather not be creating a new string object every time can you change this to:
Base.default_timezone == :utc ? time : time.getlocal
|
@pixeltrix Thank you for many responses. I've updated them. |
…ts string with timezone. Closes rails#12278.
|
I've rebased this PR . |
Closes #12278. AR::ConnectionAdapters::Column.string_to_time method respects string with timezone.
|
@kennyj thanks! |
Closes #12278.
In current implementation,
AR::ConnectionAdapters::Column.string_to_timemethod ignores timezone.If with timezone (e.g. Wed, 04 Sep 2013 20:30:00 JST), the method should respects its timezone.