Ruby debugger corrections #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| class KernelDeuggerTest < Test::Unit::TestCase |
There was a problem hiding this comment.
damn it!
thanks for catching that
one sec ...
…hod is added by ruby-debug and should be left as is. Missing tests added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
Here are some minor corrections to ActiveSupport core_ext/kernel debugger related code, one which removes a
require_library_or_gem, which is bad practice imo, and subsequent requires (which were unused). And another commit which removes AS removingbreakpointfromKernelif it existed, this is added byruby-debugas an alias and I am not sure why Rails would say its been renamed.I think this is good to apply to 3-1-stable and master, but I leave that up to you.
Thanks,
Josh