Fix ActiveSupport::Inflector.pluralize behavior for words that consist of non-ASCII characters #12509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @fxn |
ghost
assigned 
|
Is this the reason why for example: inflect.uncountable 'stück'
inflect.uncountable 'equipment'["stück".pluralize, "equipment".pluralize]
=> ["stücks", "equipment"]has this been fixed in rails master? |
The code below returns "猫" in 3.2, but "猫s" in 4.0. ```ruby ActiveSupport::Inflector.inflections do |inflect| inflect.uncountable "猫" end "猫".pluralize ```
eitoball
force-pushed
the
pluralize_for_non_ascii_character_words
branch
from
ace7d78
to
c7fc843
Compare
Yes.
I think not yet. I just rebased on master without conflicts. |
matthewd
added a commit
that referenced
this pull request
Dec 31, 2016
…cter_words Fix ActiveSupport::Inflector.pluralize behavior for words that consist of non-ASCII characters (test only; the original bug was fixed by 1bf50ba)
|
This got fixed (accidentally, it would seem) by 1bf50ba. I've merged this for the new test, to ensure it stays fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes behavior of
ActiveSupport::Inflector.pluralize.The code below returns "猫" in 3.2, but "猫s" in 4.0.