Make logging to stdout work again with implicit development env
#12514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,8 @@ def parse!(args) | |||
|
|
|||
| opt_parser.parse! args | |||
|
|
|||
| options[:log_stdout] = options[:daemonize].blank? && options[:environment] == "development" | |||
| options[:log_stdout] = options[:daemonize].blank? && | |||
| (options[:environment] || ENV["RAILS_ENV"] || ENV["RACK_ENV"] || "development") == "development" | |||
There was a problem hiding this comment.
Could not we use Rails.env?
There was a problem hiding this comment.
I considered that, but it relies on ENV['RAILS_ENV'] for the check, which gets only assigned by set_environment when a Rails::Server instance is initialized. I don't see a way to pass command line args (-e development) to Rails::Server.new; apparently this is only possible by starting the server. This would then be very difficult to write a test for.
Maybe you see a better solution which is more DRY?
There was a problem hiding this comment.
options[:environment] || Rails.env || "development"?
|
@rafaelfranca Got it now, thanks! (Though it required some dirty fighting against the fact that |
rafaelfranca
added a commit
that referenced
this pull request
Oct 13, 2013
…development-env Make logging to stdout work again with implicit `development` env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11060 disabled logging of
rails serverto stdout in non-development environments. It did so by checking whether-e developmentwas passed explicitly. However, development environment can also be set using theRAILS_ENVorRACK_ENVvariables or by not specifying an environment at all. In these cases, logging to stdout was suppressed, too. This means that simply runningrails serverwould no longer output anything. This PR fixes the problem and adds further tests.