Always check to see if methods exist after calling define_attribute_methods #12632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tenderlove |
|
Ah great. Another check-then-act race condition. I should've caught this in b670d79. Thanks! |
tenderlove
added a commit
that referenced
this pull request
Oct 24, 2013
Always check to see if methods exist after calling define_attribute_methods
tenderlove
added a commit
that referenced
this pull request
Oct 24, 2013
Always check to see if methods exist after calling define_attribute_methods
|
Great! I cherry-picked some commits related to this on 4-0-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug isolated in #12607 where two threads that both dispatch into
method_missingwill result in only one of them successfully calling the newly-created method.No idea how to test this, especially since the bug only appears in a threaded environment under very specific timing conditions.