Refactor File.expand_path usage to remove additional File.join

[notalex]

File.join might not be required when File.expand_path is being used, unless we want to make it work on windows. I feel that removing the extra File.join part simplifies the code. If there is actually an advantage in using File.join with expand_path, it would be good to know.

[rafaelfranca]

We want to make it work on windows. So I guess we can't change right?

[notalex]

@rafaelfranca, I tried it out on a windows machine inside VirtualBox. The following code works on ruby2.0.0-p247, ruby1.9.3-p448 & ruby1.8.7-374.

file_path = 'actionview/test/actionpack/abstract/helper_test.rb'
File.expand_path('../../../fixtures/helpers_missing', file_path) # => 'actionview/test/fixtures/helpers_missing'

File.expand_path('~/.railsrc')   # => 'C:/Documents and Settings/notalex/.railsrc'

Since Ruby internally deals with Windows path in the Unix way, I guess this patch would work on windows as well.

[notalex]

I am adding a fix for another line, which I was unsure of before.

[senny]

@rafaelfranca even the documentation suggests the use of / inside the String passed to expand_path. This should be safe to use even for windows: http://www.ruby-doc.org/core-2.0.0/File.html#method-c-expand_path

[senny]

@notalex thank you for your contribution 💛