Updated ActiveRecord::Base.find_or_create_by for 2 attributes when 1 is n #1276
Conversation
…is nil
Updated the find_or_create_by_foo_and_bar('hello') to process the find portion
similar to find_by_foo_and_bar('hello'). In the original
find_by_foo_and_bar('hello'), the resulting query was something like
"foo = 'hello' AND bar IS NULL". In the original
find_or_create_by_foo_and_bar('hello'), the resulting query was something like
"foo = 'hello'"
This patch aligns those two methods expected behaviors on the "find" portion
of the method call.
|
Interesting. I feel like it should instead raise an error if you're doing /cc @tenderlove |
|
Given that find_by_foo_and_bar will not raise an error if only one param is passed, I'd expect find_or_create_by_foo_and_bar to behave the same. Having these two related functions behave differently on missing parameters is a big no no for me. And altering the find_by_foo_and_bar to raise an error on a missing parameter will likely break existing applications. |
|
@jeremyf Is this still an issue? |
|
Yeah. I don't remember but seems like @jonleighton want to remove the dynamic finders in the next version. If so, please close this one @jonleighton |
|
If we are removing dynamic finders, then I'll close it. |
Updated ActiveRecord::Base.find_or_create_by for 2 attributes when 1 is nil
Updated the find_or_create_by_foo_and_bar('hello') to process the find portion
similar to find_by_foo_and_bar('hello'). In the original
find_by_foo_and_bar('hello'), the resulting query was something like
"foo = 'hello' AND bar IS NULL". In the original
find_or_create_by_foo_and_bar('hello'), the resulting query was something like
"foo = 'hello'"
This patch aligns those two methods expected behaviors on the "find" portion
of the method call.