Skip test which is broken on jruby #12816
Conversation
This test is broken from quite a while & is expected to remain broken as encoding issues are hardest to fix in JRuby. so lets skip this test for now
Skip test which is broken on jruby
| @@ -37,6 +37,10 @@ def test_serves_static_index_file_in_directory | |||
| end | |||
|
|
|||
| def test_served_static_file_with_non_english_filename | |||
| if RUBY_ENGINE == 'jruby ' | |||
There was a problem hiding this comment.
Any reason why we don't use jruby_skip here please ? :-)
There was a problem hiding this comment.
jruby_skip is only available in ActiveSupport as its defined in abtract_unit.rb. And caused an NoMethodError exception when I tried to use it here.
if you know a way that jruby_skip can be used in entire codebase, kindly let me know. I would happy to submit a PR
There was a problem hiding this comment.
It looks like you are right ; currently it's not possible (in a clean way I mean) to load Active Support's abstract unit in Action Pack's. I thought we could move it to ActiveSupport::TestCase but I don't think this should be public API. What do you think @rafaelfranca ?
There was a problem hiding this comment.
Here is what I think
- for code reuse. we can either inherit from common class(
ActiveSupport::Testing::Assertions?) which would make this a public api OR make it a module which can be included in abstract units of all rails components. But making a module for just for 2 helper methods would be overkill. - Alternatively, if some code duplication is okay, we can paste following line in abstract unit of AS & AP
%w[jruby rbx].each do |runtime|
define_method("#{runtime}_skip") {|msg=''| skip msg if RUBY_ENGINE == runtime}
endthis would generate jruby_skip & rbx_skip methods. IMHO, this is the simplest approach & what I would like to do. so let me know if its okay, I will submit a PR.
This test is broken from quite a while & is expected to remain broken as
encoding issues are hardest to fix in JRuby. so lets skip this test for
now.
Related bug report: http://jira.codehaus.org/browse/JRUBY-7192
#11700