Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rescue with a splat rather and catching all exceptions and manually filtering in Kernel#suppress #12882

Merged
merged 1 commit into from
Nov 14, 2013

Conversation

haileys
Copy link
Contributor

@haileys haileys commented Nov 14, 2013

No description provided.

@guilleiguaran
Copy link
Member

👍

guilleiguaran added a commit that referenced this pull request Nov 14, 2013
Use rescue with a splat rather and catching all exceptions and manually filtering in Kernel#suppress
@guilleiguaran guilleiguaran merged commit 416a9c7 into rails:master Nov 14, 2013
@haileys haileys deleted the use-rescue-splat-in-suppress branch November 14, 2013 06:51
@haileys
Copy link
Contributor Author

haileys commented Nov 14, 2013

Whoops just realised we can get rid of the => e too. It's probably not worth submitting another PR for, I guess you can just fix that and commit it straight to master?

@guilleiguaran
Copy link
Member

@charliesome thanks, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants