Add AR::Base.to_param for convenient "pretty" URLs derived from a model's attribute or method

[javan]

Example:

class User<ActiveRecord:: Base
  to_param : name
end

user = User.find_by(name: 'Fancy Pants')
user.id       # => 123
user.to_param # => "123-fancy-pants"

[rafaelfranca]

Thank you but we can't change the Rails default and this is already possible to do in your application. We don't need this on Rails

[rafaelfranca]

Now I got what the PR is doing. 😰

[dhh]

It's all opt-in, all good :)

[rafaelfranca]

We need tests to this truncate logic

[javan]

@rafaelfranca Look OK? https://github.com/rails/rails/pull/12893/files#diff-6c21f4fa097b56799e5156e7b686fe28R31

[xymbol]

Hmm, a bit astonished to find this merged to master "as is". This implementation ignores all prior art on the subject, for example, FriendlyId. The code seems pretty expensive to generate, say, hundreds of resource urls for an index page. What's the need for uncached interpolation, truncation, parameterization, etc.? Yes, it's optional but, it's being offered as a convenience for people to use.

[dhh]

FriendlyId is great but far too complex for something default to fit in Rails. This is a great simple solution that'll be a nice upgrade for the 80% case. For when you want to go for the last 20%, external gems can fill the gap.

If you have some performance benchmarks showing this approach is an issue, do post along with a patch to speed it up. But the core functionality is solid as is.

On Dec 18, 2013, at 7:06, Adrian Mugnolo notifications@github.com wrote:

Hmm, a bit astonished to find this merged to master "as is". This implementation ignores all prior art on the subject, for example, FriendlyId. The code seems pretty expensive to generate, say, hundreds of resource urls for an index page. What's the need for uncached interpolation, truncation, parameterization, etc.? Yes, it's optional but, it's being offered as a convenience for people to use.

—
Reply to this email directly or view it on GitHub.

[rafbm]

The one thing that feels wrong to me in this addition is the hard 20 passed to truncate. I think a max_length option would bring a nice flexibility.

class User < ActiveRecord::Base
  to_param :name, max_length: 40
end

Using 20 as the default length seems a bit short to me too (think blog post slugs), but I guess this really depends on your use case.

[Fire-Dragon-DoL]

Yes sounds important the possibility to use an option

[kuldeepaggarwal]

Please refer this #12967.