Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Typos Corrected and Queen's English -> American English Translations #1310

Closed
wants to merge 1 commit into from
Closed

Conversation

leereilly
Copy link
Contributor

You'd think I was a grammar nazi or something, but I found one and went on a hunt to find some more. I am of course making the assumption that all code/documentation should be in American English as opposed to British English..?

Cheers,
Lee 🍺

@tenderlove
Copy link
Member

hmmm

🍺

@tenderlove
Copy link
Member

@leereilly do you mind rebasing so I can lazily apply this from github?

@leereilly
Copy link
Contributor Author

I saaaaay....!

NP - just let me review http://learn.github.com/p/rebasing.html and get back to you...

@leereilly
Copy link
Contributor Author

OK I RTFM. I have a new branch @ https://github.com/leereilly/rails/tree/my_new_branch - should I initiate a new pull request from there... or is there some Git(hub) magic I can use?

Thanks for your patience!

Cheers,
Lee 🍺

@tenderlove
Copy link
Member

@leereilly ya, just send a new pull request from that branch. I'll close this one and apply your new one.

@tenderlove tenderlove closed this May 25, 2011
jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[rails#1310 state:committed]
jake3030 pushed a commit to jake3030/rails that referenced this pull request Jun 28, 2011
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[rails#1310 state:committed]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants