allow for arrays to be defined as symbol

[jigfox]

change_colum :table, :column, :bigint, array: true didn't work because
the array option tried to string concat: :bigint << '[]'

I don't know if this is the right place to convert the possible symbol
to a string. If it's wrong please let me know a better place and I will
change this.

[senny]

@jigfox if you look at the test a few lines below it seems that symbols are already working...

@connection.change_column :pg_arrays, :snippets, :text, array: true, default: "{}"

[senny]

@jigfox I think you hit a special case with bigint. Looking at the implementation of type_to_sql I see that you should probably use :integer, limit: 8. See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L456

I'll investigate and let you know what I find out.

[jigfox]

Okay, I just started writing that it seems to be a special case for :bigint

I know I could have used limit: 8, but IMHO it should work with bigint, too

[senny]

The docs say:

You may use a type not in this list as long as it is supported by your database (for example, “polygon” in MySQL), but this will not be database agnostic and should usually be avoided.

The example uses a String but I agree that it should behave the same way if you use a Symbol. However patching change_column only in the PG adapter is at the wrong level. I'll look into it and prepare a patch.

[jigfox]

psotgres seems to be the only database to support the array option

[senny]

@jigfox I commited be5527b to fix the problem. type_to_sql now has a consistent signature and will always return a String. This will allow dependent code like change_column to perform String operations like << on the result.

Thank you for reporting 💛

[jigfox]

@senny Thanks, that was pretty fast

[senny]

@jigfox you're welcome. I backported the fix to 4-0-stable to be released with the next 4.0.x release.