Minitest upgrade broke build #13213
Merged
Minitest upgrade broke build #13213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ module Isolation | |||
| def self.included(klass) #:nodoc: | |||
| klass.extend(Module.new { | |||
| def test_methods | |||
| ParallelEach.new super | |||
| Parallel.new super | |||
There was a problem hiding this comment.
Thanks, but I'm not sure that's gonna work, it seems the API has changed and Parallel is now a module. Maybe we should make use of the parallelize_me! method, not sure.
|
/cc @tenderlove |
|
This seems to be another fix for both 1.9.3 and 2.0.0 (which wasn't broken for me). I'm not sure if it's actually running in parallel or not, but the suite passes again. diff --git a/activesupport/lib/active_support/testing/isolation.rb b/activesupport/lib/active_support/testing/isolation.rb
index d5d31ce..18c48a7 100644
--- a/activesupport/lib/active_support/testing/isolation.rb
+++ b/activesupport/lib/active_support/testing/isolation.rb
@@ -1,5 +1,5 @@
require 'rbconfig'
-require 'minitest/parallel_each'
+require 'minitest/parallel'
module ActiveSupport
module Testing |
|
Doh, ignore me. @arunagw already had that in his diff. Sorry about the noise. |
minitest/minitest@34760e3 This PR should fix build
tenderlove
added a commit
that referenced
this pull request
Dec 6, 2013
Minitest upgrade broke build
chancancode
added a commit
to chancancode/rails
that referenced
this pull request
Dec 8, 2013
We made a change in rails#13213 that depends on a new file that's only in minitest 5.1.0+, so the version should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minitest/minitest@34760e3
This PR should fix build