Some improvements on building nested forms. [ci skip] #13214
Conversation
JuanitoFatas
commented
Dec 6, 2013
JuanitoFatas
commented
- Change 9.2 title from Building the Form to Building Nested Form.
- Make the example of 9.2 met with example below.
- 9.4 punctuation fixes & readability (inline code snippet).
- Fix 9.4 code example.
| @@ -859,7 +859,7 @@ end | |||
|
|
|||
| This creates an `addresses_attributes=` method on `Person` that allows you to create, update and (optionally) destroy addresses. | |||
|
|
|||
| ### Building the Form | |||
| ### Building Nested Form | |||
There was a problem hiding this comment.
either "A Nested Form" or "Nested Forms" (the latter is probably better)
There was a problem hiding this comment.
Changed. Thanks.
|
Also, I have a huge favor to ask from you. I noticed that you are also fixing warpping the lines as you are editing this file, which is great. However, due to the way diffing works, this makes it pretty much impossible to tell what actually changed 😢 Also, the file is now inconsistently warpped. Can I suggest that you split this into two commits, the first one fixing the wording, the second one fixing the lines in the whole file in one go? HUGE thank you for this one in advance! |
|
Also, thank you for taking your time to submit this, helping to make Rails better 💙 |
|
@chancancode I would love to but I think we should just change the wording (and surrounding word wraps) in this commit and avoid the whole file wrap changes (this is cosmetic change). |
|
@chancancode No unnecessary word wrap. Thank you for your time to work on this. |
Some improvements on building nested forms. [ci skip]
|
Thank you ❤️ 💚 💙 💛 💜 |
|
I thank you for collaboration. It's really late in my Time zone. So I reply very short. I am sorry for this. Thank you again. |
