Fix typecasting array of integers #13451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #13444
| def test_type_cast_integers | ||
| x = PgArray.new(ratings: ['1', '2']) | ||
| assert x.save! | ||
| assert_equal(['1', '2'], x.ratings) |
There was a problem hiding this comment.
shouldn't this be assert_equal([1, 2], x.ratings) ?
There was a problem hiding this comment.
It will be once we save the record.
Unfortunately, with the way things work currently, the attribute's value is what we provide it, even though the values are typed when saved in the database.
There was a problem hiding this comment.
I did some work on json and hstore columns a while back to cast them directly, I'll look into it for array columns too. This is another discussion though. Patch looks good.
senny
added a commit
that referenced
this pull request
Dec 22, 2013
Fix typecasting array of integers
senny
added a commit
that referenced
this pull request
Dec 22, 2013
Fix typecasting array of integers
|
Thank you Yves 😘 |
|
Thanks to both of you! ❤️ |
senny
added a commit
that referenced
this pull request
Dec 22, 2013
senny
added a commit
that referenced
this pull request
Dec 22, 2013
Conflicts: activerecord/CHANGELOG.md
senny
added a commit
that referenced
this pull request
Dec 22, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When typecasting an array of integers, if the value happens to be provided as strings (in forms for example),
quote_and_escapewill receive aNumericand try gsubing on it.This fixes it, returning the value without modifying it.
Closes #13444