Add any/all support for variants

[lukaszx0]

Like format.any, you can do the same with variants now.

It works for both inline:

respond_to do |format|
  format.html.any   { render text: "any"   }
  format.html.phone { render text: "phone" }
end

and block syntax:

respond_to do |format|
  format.html do |variant|
    variant.any(:tablet, :phablet){ render text: "any" }
    variant.phone { render text: "phone" }
  end
end

Regarding implementation, VariantFilter was removed and VariantCollector is used for both inline and block syntax. This is needed, as now we don't know what variant should be rendered until we collect all of them (any complicates this).

In the end, I think this is even better. Implementation is cleaner and more consistent because we don't have 2 different things - filter and collector - but only one, which takes care of everything.

/cc @dhh

[dhh]

Will format.any(:none, :phone) work as well?

[lukaszx0]

It will but for format, not variant. Formats have its own collector (for mime type negotiation) and it implements it's own any method here: https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/metal/mime_responds.rb#L446-L453

I've just added test case which should clarify you whole the thing: lukaszx0@3c33f36#diff-a528c4ecc381b6bf63516c4f2ed063c4R233.

You could've ask also if implicit rendering will work when using any on variant but without passing a block. Yes it will and I've added test case for it as well: lukaszx0@3c33f36#diff-a528c4ecc381b6bf63516c4f2ed063c4R226

[asiniy]

It looks good, but why it's broken? @strzalek do you need a help with commit?

[lukaszx0]

It's definitely not broken. AP and AV are passing, railties and database related tasks are failing because they're are broken after recent changes on master. We're working on fixing this, please check other PRs.

[asiniy]

okay. Where do you think I can contribute to?

[lukaszx0]

Here's latest build on master: https://travis-ci.org/rails/rails/builds/15958111, you can check what's broken and send PR with a fix. I must say though, that because of holidays I'm not up to date and there might be PR with fixes sent already (good idea to check that fist).

Besides that, there's a ton to do! We have 700+ open issues (https://github.com/rails/rails/issues?direction=desc&labels=&sort=updated&state=open), fixing any of it would be a great help. If you've never contributed to rails this might be a bit hard and overwhelming for the first time but helping out by providing feedback for the issues, like how to reproduce it or confirming that it exists would be helpful as well. I would recommend to start with browsing issues labeled with intermediary level (https://github.com/rails/rails/issues?direction=desc&labels=Level%3AIntermediary&page=1&sort=updated&state=open), they should be fairly easy to start with. Check out also contributor's guide where you find all informations that will help you prepare your first patches (http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html).

If you have any further questions do not hesitate to shoot me an email (you can find my email address on my github profile page). I'll happily answer to any!

Hope that helps, looking forward to your contributions! Thanks!

[egilburg]

I think this can be simplified to:

if args.any? && args.none?{ |a| a == @variant }

[lukaszx0]

Yep. Thanks!

[dhh]

Sorry, I meant variant.any(:none, :phone). Basically that you can include the none case together with named variants.

[lukaszx0]

@dhh oh yeah, sorry. Sure, it will work. I've just added another test case to assure that (lukaszx0@a288cc1#diff-a528c4ecc381b6bf63516c4f2ed063c4R726) 😉