Fix railties tests in master #13472
Merged
Fix railties tests in master #13472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are failing due to missing env var on master https://travis-ci.org/rails/rails/jobs/15930622#L641 This adds an environment variable `ENV['RAILS_SECRET_KEY_BASE']` so these tests will pass.
|
Thanks. I have pushed a different fix a couple minutes ago: 959cfce That should be enough, no? |
|
That test was still failing on master for me. Maybe I pulled before your fix. If master is green we can close this. |
|
@josevalim I think we should revert 959cfce because test cases are failing. See this. WDYT? |
josevalim
pushed a commit
that referenced
this pull request
Dec 24, 2013
…url-tests Fix railties tests in master
|
There's still work to be done here. Out shopping for Christmas presents. Will take a look at failures when I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are failing due to missing env var on master https://travis-ci.org/rails/rails/jobs/15930622#L641
This adds an environment variable
ENV['RAILS_SECRET_KEY_BASE']so these tests will pass.