Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default production database to URL sub key #13569

Merged
merged 1 commit into from
Jan 2, 2014

Conversation

schneems
Copy link
Member

@schneems schneems commented Jan 1, 2014

By using the URL sub key in the database.yml by default we are exposing the ability to set other attributes such as pool or reap_frequency without need of modifying the URL to contain non-connection specific information.

By using the URL sub key in the `database.yml` by default we are exposing the ability to set other attributes such as `pool` or `reap_frequency` without need of modifying the URL to contain non-connection specific information.
rafaelfranca added a commit that referenced this pull request Jan 2, 2014
Move default production database to URL sub key
@rafaelfranca rafaelfranca merged commit 55dc36b into rails:master Jan 2, 2014
@josevalim
Copy link
Contributor

@schneems at this point, does it make sense to remove support to the previous mechanism? As it was added just for 4.1?

@schneems
Copy link
Member Author

schneems commented Jan 3, 2014

Life would be slightly easier if we remove the production: "postgres://localhost/foo" case. Having the return value of a key always be one type (a Hash) instead of potentially two types reduces our code paths. Was this feature documented anywhere? What besides taking out the code do we need to do to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants