Favor canonical environment variables for secrets #13703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixing an environment variable with
RAILS_
should be used when there is otherwise a conflict, such asRAILS_ENV
or if it is being used for a very Rails specific value.If we remove the prefix of
RAILS_
in the case ofRAILS_SECRET_KEY_BASE
then we can push for a pseudo standard among other frameworks that will accept a common environment keySECRET_KEY_BASE
to keep your app secure. This is beneficial for containerized deployments such as docker, Heroku, etc. So that the container need to know one less thing about your app (it can just set it no-matter what language or framework you are using).This change also allows the defaults to be consistent with the way the secret key is accessed so
secrets.secret_key_base
is aliased toSECRET_KEY_BASE
instead ofRAILS_SECRET_KEY_BASE
.