Rails config for raise on missing translations

[kassio]

Add a config to setup whether raise exception for missing translation or
not.

Fixes #13196

[robin850]

What do you think about something like:

Specify whether an error should be raised for missing translations

[robin850]

Hello @kassio, thanks for your contribution. This looks like a quite tiny patch that could be pretty useful! However, I'm not a merger so let's wait for some feedback before addressing the comments.

Also, what do you think about changing the changelog entry to something like:

Added `config.action_view.raise_on_missing_translations` to define whether an
error should be raised for missing translations.

[kassio]

@robin850 thank's for the comments, I did the changes.

[rafaelfranca]

I think this logic can be improved to something like:

options[:raise] ||= ActionView::Base.raise_on_missing_translations

if options.key?(:rescue_format)
  raise_error = options[:rescue_format]
else
  raise_error = options[:raise]
end

[kassio]

WDYT:

options[:raise] ||= ActionView::Base.raise_on_missing_translations

raise_error = options[:raise] || options.key?(:rescue_format)
unless raise_error
  options[:raise] = true
end

[rafaelfranca]

seems good

[derekprior]

Thanks @kassio! Can we back port this to 4.0.x and 3.2.x since it was a regression?

[rafaelfranca]

I consider this is a new feature so I'd not backport. But if we would backport we would only do to 4.0

[fguillen]

In which version of Rails is this commit merged?

In Rails 4.0.2 I have the error:

NoMethodError: undefined method `raise_on_missing_translations=' for ActionView::Base:Class

[carlosantoniodasilva]

@fguillen it's been merged to master only.

[firedev]

What about disregarding missing translations for default language? #13429

[fguillen]

Sorry @firedev but I don't know what you mean :/

[firedev]

Well, it is all described in the ticket, since rails 4.0.2 there seem to be no way to work around missing translations.

[fguillen]

@firedev I'm using your workaround:

# application_helper.rb
if(Rails.env.development? || Rails.env.test?)
  def t(key, opts = {})
    opts = opts.merge(:raise => true)
    I18n.t(key, opts)
  end
end

I know you can't intercept the exception but at least I have an exception :)

[firedev]

I just want <span class="missing_translation" title="Missing translation for en.Welcome"> to not show up for English locale.

[fguillen]

I see. Looks like you are trying hard: http://stackoverflow.com/questions/12558716/disable-translation-missing-for-english-only-in-rails luck with this!

[firedev]

And by the way I tried to add

config.action_view.raise_on_missing_translations = false

To application.rb, nothing changed.

[edwinv]

I'm not completely sure what is going on, but I too have issues with a custom exception handler for I18n. We are using an exception handler that stores missing translations in a separate file. Before Rails 4.1, we needed to override the Rails helper to always use raise: false. With the new configuration this can be configured, which is way nicer than a monkey patch.

Unfortunately, our previous setup only works when supplying the rescue_format: true key to the translation helper. Only then the exception handler is called and we right missing translation missing is returned. It seems cumbersome to always include this key in each call to the Rails helper and it completely eliminate all benefits from the configuration setting.

Before Rails 4.1: t(".foobar", raise: false) calls the exception handler in the right way

After upgrading to 4.1: t(".foobar", rescue_format: true) calls the exception handler when config.action_view.raise_on_missing_translations=false is set.

[firedev]

Just to reiterate, before 4.0.2 was out I intercepted missing translations for english and I didn't have to bother about en.yml. Now I do have config.action_view.raise_on_missing_translations=false in my application.rb but the whole page is covered in missing_translation spans.

[edwinv]

@firedev I think everyone gets your point now... Maybe you can add something valuable to the ticket to help @kassio to debug this matter further. Does you setup work when adding rescue_format: true to your calls to the translation helper?

[firedev]

Sorry, I am just a bit frustrated. Don't see rescue_format: true changing anything.

Also I have tried different error handlers with config.action_view.raise_on_missing_translations=true, this indeed raises I18n::MissingTranslationData error, but I couldn't intercept it.

[tigrish]

I've created #17676 that fixes this regression.

@edwinv note that config.action_view.raise_on_missing_translations means "raise the exception from ActionView" not, "pass the raise option to I18n". Unfortunately this means that monkepatching raise: false is still necessary to use a custom exception handler.