Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guides] Add documentation for using Rails with a reverse proxy [ci skip] #13988

Merged
merged 1 commit into from
May 24, 2014

Conversation

zzak
Copy link
Member

@zzak zzak commented Feb 9, 2014

No description provided.

@zzak
Copy link
Member Author

zzak commented Feb 9, 2014

(un)related: if the pull-request title has [ci skip], but the commit doesn't, is travis still skipping?

@carlosantoniodasilva
Copy link
Member

It needs to be on the commit, otherwise it runs now and after the merge it runs again. Mind amending the commit to add ci skip?

TODO
Alternatively, you can use [unicorn](http://unicorn.bogomips.org/) to run your
application behind a reverse proxy. You can find more information in the
[unicorn readme](http://unicorn.bogomips.org/index.html#label-Usage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anchor is not working, also I think better to point to http://unicorn.bogomips.org/PHILOSOPHY.html page where is described more about reverse proxing. what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pftg That's because I committed this on a plane without internet, I was just guessing based of what is generated from RDoc on the unicorn source.

It also seems likely that the unicorn docs haven't been generated with a modern version of RDoc in a while, so it's missing the anchor tags.

Let's leave this open until we can fix up the unicorn README and get them to regenerate the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is specifically about deploying to a subdirectory. We should explain the rough basics how things have to be setup on the proxy side and the application server.

Unicorn is just one possibility so it would be better to explain the concepts isolated from proxy / application server.

@zzak
Copy link
Member Author

zzak commented Feb 9, 2014

@carlosantoniodasilva Sure! I need to fix the link before I force --push ❤️

@vijaydev
Copy link
Member

vijaydev commented May 2, 2014

@zzak ping!

@zzak
Copy link
Member Author

zzak commented May 16, 2014

@senny @vijaydev I've updated the patch given your feedback, please check it <3


Many modern web servers can be used as a proxy server to balance third-party elements such as caching servers or application servers.

One such application server you can use is [unicorn](http://unicorn.bogomips.org/) to run behind a reverse proxy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/unicorn/Unicorn - here and all other instances.

@robin850
Copy link
Member

@zzak : Could you wrap your additions around 80 chars please ? This looks good to me so far, thanks! :-)

@zzak
Copy link
Member Author

zzak commented May 24, 2014

@robin850 I didn't wrap because that would be inconsistent with the rest of the document.

zzak pushed a commit that referenced this pull request May 24, 2014
[Guides] Add documentation for using Rails with a reverse proxy [ci skip]
@zzak zzak merged commit 50d4f59 into rails:master May 24, 2014
@zzak zzak deleted the guides_configuring_reverse_proxy branch May 24, 2014 15:55
@robin850
Copy link
Member

I didn't wrap because that would be inconsistent with the rest of the document.

Yup I know, but we are slowly wrapping new additions anyway to avoid making a big commit that'd make git blame a mess but I guess we will have to since nobody wrap their addition. Thanks for the patch anyway! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants