Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails.threadsafe! mode is deprecated, Update Docs #13998

Merged
merged 1 commit into from
Feb 9, 2014
Merged

Rails.threadsafe! mode is deprecated, Update Docs #13998

merged 1 commit into from
Feb 9, 2014

Conversation

gaurish
Copy link
Contributor

@gaurish gaurish commented Feb 9, 2014

Rails.threadsafe! mode is deprecated, update docs to reflect this.

robin850 added a commit that referenced this pull request Feb 9, 2014
`Rails.threadsafe!` mode is deprecated, Update Docs [ci skip]
@robin850 robin850 merged commit 3a428f3 into rails:master Feb 9, 2014
@robin850
Copy link
Member

robin850 commented Feb 9, 2014

Thank you @gaurish!

@arunagw
Copy link
Member

arunagw commented Feb 9, 2014

Hey @gaurish would you like to get access to docrails repo?
If you want to contribute more in docs 😄. With access you can directly push to docrails for guides changes.

@gaurish
Copy link
Contributor Author

gaurish commented Feb 9, 2014

@arunagw Yes, please 👍

@fxn
Copy link
Member

fxn commented Feb 13, 2014

I believe this edit should read "If you are running in a multi-threaded environment", the fact that Rails is multi-thread by default is not very relevant.

It was before, with the previous wording people only enabled threading if they needed it.

@robin850
Copy link
Member

@fxn : Sorry ; I merged it a bit too quickly.

@gaurish : Would you mind committing the proposed changed by @fxn to docrails ? If you can't, I can do it. :-)

@fxn
Copy link
Member

fxn commented Feb 15, 2014

@robin850 no prob at all! ❤️

@gaurish
Copy link
Contributor Author

gaurish commented Feb 23, 2014

@robin850
Copy link
Member

Thank you @gaurish! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants