do not crash when config/secrets.yml
is blank.
#14029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an application I was facing the following issue:
Our setup script touches a blank
config/secrets.yml
and then executes tasks that load the environment to populate it. In an initializer there is a condition on the existence of a secret. This currently crashes as the loading process expects the file to be populated:The use-case presented above is certainly esoteric and could probably be solved otherwise. However I think we should not crash on a blank
config/secrets.yml
with this cryptic error.Currently a blank
config/database.yml
yields:After this patch a blank
config/secrets.yml
will result in: