Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized punctuation. #14186

Merged
merged 1 commit into from
Feb 25, 2014
Merged

Standardized punctuation. #14186

merged 1 commit into from
Feb 25, 2014

Conversation

ch33hau
Copy link
Contributor

@ch33hau ch33hau commented Feb 25, 2014

Punctuation are not standardized, for same purpose, some use single quotation, some use double quotation:

require "yaffle/core_ext"
require 'yaffle/acts_as_yaffle'

@arthurnn
Copy link
Member

can you add a [skip ci] to the commit message?
thanks

@pmq20
Copy link

pmq20 commented Feb 25, 2014

What difference in effect does this make?

@ch33hau
Copy link
Contributor Author

ch33hau commented Feb 25, 2014

@arthurnn sorry, I'm new to opensource, is this a correct way to amend the commit message?

@ch33hau
Copy link
Contributor Author

ch33hau commented Feb 25, 2014

@pmq20 hi, no difference in code, but it might be a little difference when we trying to do searching, or reading...

@pmq20
Copy link

pmq20 commented Feb 25, 2014

I think you should git commit with --amend arg and then git push with the --force arg. Otherwise you won't override the message of the original commit and rather made another one.

@pmq20
Copy link

pmq20 commented Feb 25, 2014

@ch33hau Great spirit and also a great way to start contributing to the community. +1 😄

@ch33hau
Copy link
Contributor Author

ch33hau commented Feb 25, 2014

@pmq20 thanks...do I need to remove my second and third commits? I'm finding a way to do it...

@arthurnn
Copy link
Member

@ch33hau You should squash all your commits in one, and force push. That commit must have a [skip ci] as part of the message.

more on squashing commits http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@ch33hau
Copy link
Contributor Author

ch33hau commented Feb 25, 2014

@pmq20 @arthurnn Really thanks a lot! Learnt a lesson here.

@senny senny added the docs label Feb 25, 2014
senny added a commit that referenced this pull request Feb 25, 2014
@senny senny merged commit 418d1e5 into rails:master Feb 25, 2014
@ch33hau ch33hau deleted the standardized-punctuation branch February 25, 2014 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants