-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Move association class method notes #14211
Conversation
@fxn should we also remove the word |
The parenthesis seem to be superfluous too. |
@loganhasson thanks, can you, also, squash your commits in one? |
@arthurnn yep, will do. Should I get rid of the parenthesis too? |
@loganhasson yep please. |
@arthurnn done and done. |
Not convinced about the wording: |
@fxn you're right...that wording is strange.
slightly better? |
👍 |
Make explanation of association class methods clearer by moving notes to beginning of each example section.
This edit is good, those placeholders are not obvious for a newcomer and this remark is better there upfront. Thanks! |
[ci skip] Move association class method notes
thanks ❤️ |
Make explanation of association class methods clearer by moving notes to beginning of each example section.