test fixes for jruby #1430
test fixes for jruby #1430
Conversation
|
If you did |
|
Yes I know, we can do that for the sake of test pass but that will override the test for MRI ruby with MySQL thats why I added the condition. |
| @@ -124,7 +124,11 @@ class AttributeMethodsTest < ActiveRecord::TestCase | |||
| if current_adapter?(:MysqlAdapter) | |||
| def test_read_attributes_before_type_cast_on_boolean | |||
| bool = Boolean.create({ "value" => false }) | |||
| assert_equal "0", bool.reload.attributes_before_type_cast["value"] | |||
| if RUBY_PLATFORM =~ /java/ | |||
| assert_equal 0, bool.reload.attributes_before_type_cast["value"] | |||
There was a problem hiding this comment.
Do you mind adding another comment before this line saying something like "JRuby will returns the value before typecast as integer" or something like that? I think we might forget why this condition has to be exists at later date.
|
Does this one fails for |
|
@sikachu commits updated. Jruby with rails master is totally in bad shape. One question Are you now Rails Repo Collab ?? Just seeing a tag on your comment :-) |
|
yeah. I see you are already in Rails list ;-) |
|
I'd love to help you guys out to get jRuby to play nice with Rails. Keep them coming. regarding repo collab, I use this permission just for cleaning up tickets bin ;) |
|
@sikachu awesome.!! We will Keep stay for Jruby. |
|
I merged this into master and 3-1-stable too. |
|
@jonleighton thanks.! |
No description provided.