Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand explanation of how to set secrets.yml. #14654

Merged
merged 1 commit into from
Apr 9, 2014

Conversation

Alamoz
Copy link

@Alamoz Alamoz commented Apr 9, 2014

The guide for upgrading to Rails 4.1.0 suggests copying the existing secret_key_base from the secret_token.rb initializer to secrets.yml under the production section. This is considered insecure by default in Rails 4.1.0, which generates a secrets.yml containing <%= ENV["SECRET_KEY_BASE"] %> for production mode:

production:
  secret_key_base: <%= ENV["SECRET_KEY_BASE"] %>

This expanded explanation shows both ways of setting secret_key for production mode.

@arthurnn
Copy link
Member

arthurnn commented Apr 9, 2014

👍 make sense to me..
@rafaelfranca thoughts?

rafaelfranca added a commit that referenced this pull request Apr 9, 2014
Expand explanation of how to set secrets.yml.
@rafaelfranca rafaelfranca merged commit 040a1db into rails:master Apr 9, 2014
rafaelfranca added a commit that referenced this pull request Apr 9, 2014
Expand explanation of how to set secrets.yml.
@Alamoz Alamoz deleted the secret_key branch April 9, 2014 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants