Fixed duplicate subscribers in ActiveSupport::Subscriber #15037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveSupport::Subscriber no longer creates multiple subscribers when you redefine a method.
|
btw: this broke only recently in 4.1.1. This is the changeset that introduced that regression: d2824a3 |
| end | ||
| end | ||
|
|
||
| attr_reader :patterns |
There was a problem hiding this comment.
Could you add # :nodoc: to this one?
rafaelfranca
added a commit
that referenced
this pull request
May 17, 2014
…_subscribers Fixed duplicate subscribers in ActiveSupport::Subscriber Conflicts: activesupport/CHANGELOG.md Conflicts: activesupport/CHANGELOG.md
rafaelfranca
added a commit
that referenced
this pull request
May 17, 2014
…_subscribers Fixed duplicate subscribers in ActiveSupport::Subscriber Conflicts: activesupport/CHANGELOG.md
|
+1 Will it be shipped in 4.1.2? |
|
@bogdan : Normally yes, the merge commit has been backported to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport::Subscriber no longer creates multiple subscribers when you redefine a method.