Use with_translation helper to clean up I18n stored translations. #15083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_send_mail | ||
| with_translation 'de', email_subject: '[Signed up] Welcome' do | ||
| get '/test/send_mail' | ||
| assert_equal "Mail sent", @response.body |
There was a problem hiding this comment.
shouldn't this test at least have an assertion about the translation?
|
@senny I've changed the test case slightly so that the translation is also tested. Is it okay? I don't see why we need |
|
Was |
|
@senny yes but why do we put recipient in the subject? |
|
not sure... seems to be a static value. Should be fine to remove it. |
| @@ -10,15 +10,15 @@ class I18nTestMailer < ActionMailer::Base | |||
| def mail_with_i18n_subject(recipient) | |||
| @recipient = recipient | |||
| I18n.locale = :de | |||
| mail(to: recipient, subject: "#{I18n.t :email_subject} #{recipient}", | |||
| mail(to: recipient, subject: "#{I18n.t :email_subject}", | |||
There was a problem hiding this comment.
We can get rid of the String interpolation:
mail(to: recipient, subject: I18n.t(:email_subject),
|
@senny done. |
| def setup | ||
| I18n.backend.store_translations('de', email_subject: '[Signed up] Welcome') | ||
| def test_send_mail | ||
| with_translation 'de', email_subject: '[Anmeldung] Wilkommen' do |
There was a problem hiding this comment.
nitpick, Willkommen with double l
|
@senny right... Sorry for my absolute zero knowledge in German. 😄 |
|
😏 This is looking good 👍 |
senny
added a commit
that referenced
this pull request
May 13, 2014
…controller_test Use with_translation helper to clean up I18n stored translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@senny please review. Thanks.