Use the generic type map object for mysql field lookups #15200
Conversation
|
/cc @senny |
| module Type | ||
| class HashLookupTypeMap < TypeMap # :nodoc: | ||
| def lookup(type) | ||
| @mapping[type].try(:call, type) || default_value |
|
@rafaelfranca Updated. |
|
Waiting the build run. |
| @@ -317,23 +317,17 @@ def cast_value(value) | |||
| end | |||
| end | |||
|
|
|||
| TYPES = {} | |||
| class << self | |||
| TYPES = ConnectionAdapters::Type::HashLookupTypeMap.new | |||
There was a problem hiding this comment.
is there a difference between putting a constant inside or outside the class << self block?
There was a problem hiding this comment.
delegate :register_type, to: :TYPES will fail if it's outside of the class << self block.
There was a problem hiding this comment.
is TYPES part of public api? if not, perhaps this should be class instance var instead (or cattr_reader)?
There was a problem hiding this comment.
I could not consider it part of the public API, but I'm also not opposed to that change.
There was a problem hiding this comment.
It is not. I'll make it with nodoc
There was a problem hiding this comment.
Oops, I thought I already merged this. @sgrif could you add nodoc comment?
|
@rafaelfranca Nodoc added. |
Use the generic type map object for mysql field lookups
No description provided.