Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake railties:install:migrations respects the order of railties #15269

Merged
merged 1 commit into from May 27, 2014

Conversation

arunagw
Copy link
Member

@arunagw arunagw commented May 23, 2014

This PR fixes #8930 and some stuff from #8985

I am not sure this is right way to do this but this PR has test cases to see the problem.

As @parndt did in #8985 can make this public and have code in database.rake

cc/ @m1k3

@@ -364,6 +364,9 @@ def y(*objects)
end
end

def migration_railties #:nodoc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after the #

@arunagw
Copy link
Member Author

arunagw commented May 27, 2014

@rafaelfranca PR updated.

About that #:nodoc: i found it same elsewhere but I think we need a space so update with that.

rafaelfranca added a commit that referenced this pull request May 27, 2014
rake railties:install:migrations respects the order of railties
@rafaelfranca rafaelfranca merged commit be4b3df into rails:master May 27, 2014
@parndt
Copy link
Contributor

parndt commented May 27, 2014

Hooray!

rafaelfranca added a commit that referenced this pull request May 27, 2014
rafaelfranca added a commit that referenced this pull request May 27, 2014
rake railties:install:migrations respects the order of railties
rafaelfranca added a commit that referenced this pull request May 27, 2014
rake railties:install:migrations respects the order of railties

Conflicts:
	activerecord/CHANGELOG.md
	railties/lib/rails/application.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants