[ci skip] Improve doc for ModuleConstMissing.guess_for_anonymous #15278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pixeltrix what do you think as a native English speaker? |
|
Looks good to me, the grammar is definitely better. |
| # (unless it can be proven that is not the case), and the path to the file | ||
| # that defines the constant. Anonymous modules cannot follow these | ||
| # conventions and therefore we assume that the user wants to refer to a | ||
| # top-level constant. |
There was a problem hiding this comment.
I'd change 'Dependencies assume' to 'Dependencies assumes' since it's really a singular noun and not a plural - if you replace Dependencies with Xavier then assume sounds wrong. I'd also lose the comma after the closing parenthesis. Finally there's a change from third person to first person with the 'we' in the final sentence - either change Dependencies to We or change 'we assume' to 'it assumes'.
|
cc: @fxn, @pixeltrix |
pixeltrix
added a commit
that referenced
this pull request
May 24, 2014
[ci skip] Improve doc for ModuleConstMissing.guess_for_anonymous
|
@akshay-vishnoi thanks! |
|
💚 |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.