Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all Rails 4.1.0 references in guides to 4.1.1 [ci skip] #15304

Merged
merged 1 commit into from
May 24, 2014
Merged

Update all Rails 4.1.0 references in guides to 4.1.1 [ci skip] #15304

merged 1 commit into from
May 24, 2014

Conversation

johnkferguson
Copy link
Contributor

This updates all the Rails 4.1.0 references in the guides to 4.1.1. I made this change within the guides themselves and the Rails app that is included in guides/code/getting_started. I also updated sass-rails gem to version 4.0.3, which is the version that ships with Rails 4.1.1.

@arthurnn
Copy link
Member

Not sure if we need to update all those spots, and if so, we need to automate that. I remember @rafaelfranca talked about a little short ago.. thoughts Rafael?

fxn added a commit that referenced this pull request May 24, 2014
Update all Rails 4.1.0 references in guides to 4.1.1 [ci skip]
@fxn fxn merged commit 107c27b into rails:master May 24, 2014
@zzak
Copy link
Member

zzak commented May 24, 2014

Technically this should be 4.2.0, as that is what we're using on master.

That said, @JohnKellyFerguson, could you rebase this against the 4-1-stable branch?

@fxn
Copy link
Member

fxn commented May 24, 2014

@arthurnn but until we have no automation PRs have to be merged, having obsolete versions is not an option.

@zzak
Copy link
Member

zzak commented May 24, 2014

backport what i could to 4-1-stable in 45c5f43

@johnkferguson johnkferguson deleted the guides-4.1.1 branch May 25, 2014 01:12
@JuanitoFatas
Copy link
Contributor

Previous discussion of Automation PR is here: #14996

robin850 added a commit that referenced this pull request Jul 7, 2014
As discussed in #15304, we need to automate this process but for now,
having out-of-date versions is not ideal.

Since master targets 4.2.0, let's also update references to the last 4.1
version to 4.2.0.

Finally, let's remove mentions to versions when this is not needed. The
guides cover the features of the current version anyway.

[Juanito Fatas + Robin Dupret]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants