[ci skip] Add benchmark your code section to contributing to ruby on rails guide. #15347
Conversation
|
Seems good to me. @zzak WDYT about the gramar? |
|
|
|
I use some words from Mr @tenderlove's comments on #15272 (comment). |
|
👍 on the idea. Would need to expand more on the introduction paragraph to explain "why". Things like you should only do this if it's in fact a hot path and a bottleneck, readability and understandability are also important, etc etc. But this is a good start. We can even do those after we merge his. |
| @@ -215,6 +215,40 @@ Rails follows a simple set of coding style conventions: | |||
|
|
|||
| The above are guidelines - please use your best judgment in using them. | |||
|
|
|||
| ### Benchmark Your Code | |||
|
|
|||
| Please use [benchmark-ips](https://github.com/evanphx/benchmark-ips) Gem to | |||
There was a problem hiding this comment.
Please use the [benchmark-ips] gem to
There was a problem hiding this comment.
Thanks! Updated.
|
@JuanitoFatas Please apply my suggestions, squash, and I will commit. |
|
@zzak I have applied your suggestions. Thanks! 👍 |
|
IMO we could expand on this further in the performance testing guide ;) |
…rails guide. I have seen many times that maintainers want people to use this gem to give a benchmark report. It would be nice to add it and refer to it later.
…-to-ror [ci skip] Add benchmark your code section to contributing to ruby on rails guide.
|
@JuanitoFatas Thank you! |
I have seen many times that maintainers want people to use this gem to give
a benchmark report. It would be nice to add it and refer to it later.