Move types to the top level ActiveRecord namespace

[sgrif]

ActiveRecord::ConnectionAdapters::Type::Value => ActiveRecord::Type::Value

[rafaelfranca]

Do we still need the alias? I think it will resolve fine

[sgrif]

Yes, otherwise subclasses of ActiveRecord::Base won't resolve the constant properly.

[rafaelfranca]

It should since Type is inside the same namespace. I think it is missing the autoload definition inside ActiveRecord.

[sgrif]

Subclasses of ActiveRecord::Base shouldn't inherit constants defined in the ActiveRecord namespace.

module Foo
  OUTER_CONST = "outer"

  module Bar
    MODULE_CONST = "module"
  end

  class Baz
    include Bar

    PARENT_CONST = "parent"
  end
end

class FooBaz < Foo::Baz
  PARENT_CONST
  MODULE_CONST
  OUTER_CONST # => this line errors
end

[rafaelfranca]

Right!

[rafaelfranca]

Just rebase and make sure you add the # :nodoc:

[sgrif]

Done

[sgrif]

@rafaelfranca The build failure was memcache, not the changes in this PR.