Refactor quoting of binary data to not be based on the column type #15486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @value | ||
| end | ||
|
|
||
| def unpack |
There was a problem hiding this comment.
👍 we could add # hex string (high nibble first) after the unpack call. Don't think readers know the flags inside out.
There was a problem hiding this comment.
I think renaming the method is probably sufficiently descriptive.. the nibble order is the ordinary/sane one: I suspect it's more likely to cause people hesitation to mention it at all.
There was a problem hiding this comment.
(I had no clue what that flag was)
|
@matthewd Any further feedback on this? |
matthewd
added a commit
that referenced
this pull request
Jun 3, 2014
Refactor quoting of binary data to not be based on the column type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.