Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test cases for schema dumping defaults #15533

Merged
merged 1 commit into from
Jun 6, 2014

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Jun 5, 2014

No description provided.

@@ -239,6 +239,13 @@ def except(adapter_names_to_exclude)
t.string :name
end

create_table :defaults, force: true do |t|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about creating a new TestCase in schema_dumper_test.rb and have it create this table in the setup method.

senny added a commit that referenced this pull request Jun 6, 2014
Add missing test cases for schema dumping defaults
@senny senny merged commit ecd4151 into rails:master Jun 6, 2014
@senny
Copy link
Member

senny commented Jun 6, 2014

👍

@sgrif sgrif deleted the sg-missing-schema-tests branch June 6, 2014 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants