Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization #15555

Merged
merged 1 commit into from
Jun 7, 2014
Merged

Fix capitalization #15555

merged 1 commit into from
Jun 7, 2014

Conversation

akshay-vishnoi
Copy link
Contributor

No description provided.

@fxn
Copy link
Member

fxn commented Jun 7, 2014

Although some docs still use the all-lowercase variant, they seem to have settled on "NGINX", see modern pages like http://nginx.com.

We always try to keep an eye on the way other projects spell their name and follow their spelling, for consistency, and for respect.

@akshay-vishnoi
Copy link
Contributor Author

Yes, you are right. Shall I update the PR with following modification /nginx/i to NGINX ?

@fxn
Copy link
Member

fxn commented Jun 7, 2014

If you are so kind. Also, would you mind in this PR looking for other instances of nginx in the project tree?

@akshay-vishnoi
Copy link
Contributor Author

Yes, I meant the same(to change in whole project).

@akshay-vishnoi
Copy link
Contributor Author

Well there are some instances of apache as well, what do you think about them?

@akshay-vishnoi
Copy link
Contributor Author

Hi @fxn
I have updated NGINX, Unicorn, Passenger and Apache. Please check.

@fxn
Copy link
Member

fxn commented Jun 7, 2014

They consistently use "Apache HTTP Server" in their official docs, let's do the same in our official docs.

@akshay-vishnoi
Copy link
Contributor Author

Okay, Cool. I am on it.

@fxn
Copy link
Member

fxn commented Jun 7, 2014

@akshay-vishnoi wait, I see informal "Apache" in some places like http://httpd.apache.org/docs/2.4/invoking.html. Let's stick with the informal one then.

@akshay-vishnoi
Copy link
Contributor Author

Oh.. The current PR would be fine to review then.
Also If you have idea about other terms as well. I will correct them in the same PR, so as to reduce noise. WDYT?

@fxn
Copy link
Member

fxn commented Jun 7, 2014

Looking good, thanks!

fxn added a commit that referenced this pull request Jun 7, 2014
@fxn fxn merged commit ad539dc into rails:master Jun 7, 2014
@akshay-vishnoi
Copy link
Contributor Author

Thanks 💚

akshay-vishnoi pushed a commit to akshay-vishnoi/rails that referenced this pull request Jun 14, 2014
zzak pushed a commit that referenced this pull request Jun 16, 2014
[ci skip] /mysql/i -> MySQL, Spell correct in continuation to #15555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants