Ensure engine migrations are copied in correct sequence #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we have tests? |
|
I couldn't find anything covering that rake task already, and I was weary about adding a complicated test for a single line change. I'll revisit the test for it. |
|
Current tests are here: https://github.com/rails/rails/blob/master/railties/test/railties/shared_tests.rb#L24 |
|
@josevalim - I've updated the test, thanks for pointing out that existing one. |
|
Github says I cannot apply your pull request anymore, could you please rebase? |
|
@josevalim - done. |
|
Sweet! Could you also provide a pull request for 3-1-stable in case you want it merged on 3-1? |
|
Merged. |
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rake railties:install:migrations copies & re-numbers migrations from engines in a random order. This commit ensures that they are copied in the same sequence that they are required.