Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update database.yml file as per rails 4.1.1(this application's rails ver... #15721

Closed
wants to merge 1 commit into from
Closed

update database.yml file as per rails 4.1.1(this application's rails ver... #15721

wants to merge 1 commit into from

Conversation

sachin87
Copy link
Contributor

...sion)

@fxn
Copy link
Member

fxn commented Jun 14, 2014

This sample app is never in sync, I would consider deleting it.

@sachin87
Copy link
Contributor Author

ok.

@sachin87 sachin87 closed this Jun 14, 2014
@sachin87 sachin87 deleted the update_guide_database_yml branch June 14, 2014 10:17
@sachin87 sachin87 restored the update_guide_database_yml branch June 14, 2014 10:18
@fxn
Copy link
Member

fxn commented Jun 14, 2014

@rafaelfranca @zzak what do you think?

@sachin87 sachin87 reopened this Jun 14, 2014
@sachin87
Copy link
Contributor Author

by the way i think that any source code that i get from rails repository is a part of rails, and i changed this because it should be not be confusing for new rails developers, if they try to compare newly generated application it with this sample application.

@vijaydev
Copy link
Member

@fxn I'm +1 for removing it.

@senny
Copy link
Member

senny commented Jun 14, 2014

let's remove it.

@rafaelfranca
Copy link
Member

👍 for removing. Try to keep it in sync would only make the release
process harder.
On Jun 14, 2014 11:06 AM, "Yves Senn" notifications@github.com wrote:

let's remove it.


Reply to this email directly or view it on GitHub
#15721 (comment).

@senny
Copy link
Member

senny commented Jun 14, 2014

@sachin87 thank you for reporting. I removed the sample application.

@senny senny closed this in 5223bad Jun 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants