Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/mysql/i -> MySQL, Spell correct in continuation to #15555 #15722

Merged
merged 1 commit into from
Jun 16, 2014

Conversation

akshay-vishnoi
Copy link
Contributor

cc: @fxn

@sgrif
Copy link
Contributor

sgrif commented Jun 14, 2014

These types of pull requests are nitpicky, and waste the core team's valuable time. This does not address any actual issues with the documentation.

@sgrif sgrif closed this Jun 14, 2014
@akshay-vishnoi
Copy link
Contributor Author

As @fxn mentioned in #15555:

We always try to keep an eye on the way other projects spell their name and 
follow their spelling, for consistency, and for respect.

@akshay-vishnoi
Copy link
Contributor Author

@sgrif : I know this is a not a BIG task, that's why I have tried to mark all spots of MySQL in a single PR, so as to reduce noise in future.

Thanks

@zzak zzak reopened this Jun 16, 2014
zzak pushed a commit that referenced this pull request Jun 16, 2014
[ci skip] /mysql/i -> MySQL, Spell correct in continuation to #15555
@zzak zzak merged commit 01c109a into rails:master Jun 16, 2014
@akshay-vishnoi
Copy link
Contributor Author

Thank you Sir. 💚

@fxn
Copy link
Member

fxn commented Jun 16, 2014

Yeah, welcome, we want top-quality docs and comments, and "Mysql" is not top-quality (in my book :).

@akshay-vishnoi
Copy link
Contributor Author

Okay I will not raise PR regarding naming of Other Libraries as they are not necessary, in future.

@fxn
Copy link
Member

fxn commented Jun 16, 2014

@akshay-vishnoi no, no, please do correct any misspellings you see, specially in the name of other projects.

In my mind paying attention to the way other projects spell their names is important. "SQLite" is written exactly that way, and for me writing that correctly is the minimum expression of respect you can have.

Just try to collect them in one single unit as you did in this one.

@akshay-vishnoi
Copy link
Contributor Author

Hey okay, Sorry i misunderstood your last message. Okay Thanks for the support. I will try to cover them in single PR. 😄

Also @sgrif 's concern is valid. So is there a way out for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants