Don't save through associations twice (4-0-stable) #15731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the through record gets created in an after_create hook that is defined before the association is defined (therefore after its after_create hook) get saved twice. This ensures that the through records are created only once, regardless of the order of the hooks. Backports the fix for rails#3798 to 4.1. Slightly more conservative on the callback order since it's a patch version, and required an additional special case for HABTM
| @@ -359,6 +359,7 @@ def save_collection_association(reflection) | |||
|
|
|||
| raise ActiveRecord::Rollback unless saved | |||
| end | |||
| @new_record_before_save = false unless reflection.macro == :has_and_belongs_to_many | |||
There was a problem hiding this comment.
I know we're trying to reduce the use of checking symbols like this throughout the code base, as well as removing the :has_man_belongs_to_many symbol overall. I'm not sure what a better way to do this would be but I don't think this is the best way.
There was a problem hiding this comment.
This is against 4-0-stable, not master.
There was a problem hiding this comment.
Oh whoops carry on then 😊
On Jun 14, 2014, at 12:06 PM, Sean Griffin notifications@github.com wrote:
In activerecord/lib/active_record/autosave_association.rb:
@@ -359,6 +359,7 @@ def save_collection_association(reflection)
raise ActiveRecord::Rollback unless saved end
@new_record_before_save = false unless reflection.macro == :has_and_belongs_to_many—
Reply to this email directly or view it on GitHub.
rafaelfranca
added a commit
that referenced
this pull request
Jun 19, 2014
Don't save through associations twice (4-0-stable) Conflicts: activerecord/test/cases/associations/has_many_through_associations_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the through record gets created in an after_create hook that is
defined before the association is defined (therefore after its
after_create hook) get saved twice. This ensures that the through
records are created only once, regardless of the order of the hooks.
Backports the fix for #3798 to 4.1. Slightly more conservative on the
callback order since it's a patch version, and required an additional
special case for HABTM