Refactor application of type decorators into an object #15759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class TypeDecorator | ||
| delegate :clear, to: :@decorations | ||
|
|
||
| def initialize(decorations = Hash.new({})) |
There was a problem hiding this comment.
Also since it is always a empty hash should not we remove the argument?
There was a problem hiding this comment.
Opps, just saw we create a new object on merge
There was a problem hiding this comment.
It gets called with an argument on line 39. Line 37 should return an empty hash if the key is not present. (Both will go away soon)
There was a problem hiding this comment.
Right. I forget the argument of Hash.new is the default value.
rafaelfranca
added a commit
that referenced
this pull request
Jun 16, 2014
Refactor application of type decorators into an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.