Don't type cast the default on the column #15782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to have type decorators mess with the attribute, but not the column, we need to stop type casting on the column. Where possible, we changed the tests to test the value of `column_defaults`, which is public API. `Column#default` is not.
| @@ -23,7 +23,8 @@ def prepare_column_options(column, types) | |||
| spec[:precision] = column.precision.inspect if column.precision | |||
| spec[:scale] = column.scale.inspect if column.scale | |||
| spec[:null] = 'false' unless column.null | |||
| spec[:default] = column.type_cast_for_schema(column.default) if column.has_default? | |||
| spec[:default] = schema_default(column) if column.has_default? | |||
There was a problem hiding this comment.
Less operations to do:
default = schema_default(column) if column.has_default?
spec[:default] = default unless default.nil?
matthewd
added a commit
that referenced
this pull request
Jun 18, 2014
Don't type cast the default on the column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to have type decorators mess with the attribute, but not the
column, we need to stop type casting on the column. Where possible, we
changed the tests to test the value of
column_defaults, which ispublic API.
Column#defaultis not.