Date#freeze fails when called more than once in 1.8 #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Jun 9, 2011
Date#freeze fails when called more than once in 1.8
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActiveSupport Date#freeze monkey-patch tries to call Date's metaprogrammed memoization logic every time you call Date#freeze. As a result, you can't do this:
> Date.today.freeze.freeze TypeError: can't modify frozen object from rails/activesupport/lib/active_support/core_ext/date/freeze.rb:22:ininstance_variable_set'from rails/activesupport/lib/active_support/core_ext/date/freeze.rb:22:in
freeze' from rails/activesupport/lib/active_support/core_ext/date/freeze.rb:20:ineach'from rails/activesupport/lib/active_support/core_ext/date/freeze.rb:20:in
freeze' from (irb):2The fix is simple; check to see if we've already frozen the object and don't run the memoization logic twice. Patch and unit test are attached.